Problem/Motivation

Just installed this module, and noticed that on the list of group blocks, the "Relate block" button goes to the form for creating a new block and the "Create block" button goes to the form for relating an existing block to the group. Seems like the button labels should be switched, right?

Steps to reproduce

Enable module, navigate to a group block list page, inspect buttons at top of View.

Proposed resolution

Switch the "titles" in groupblock.links.action.yml

CommentFileSizeAuthor
#2 button_text_switched-3476515-2.patch605 bytesjparmar

Comments

amerie created an issue. See original summary.

jparmar’s picture

jparmar commented
StatusFileSize
new button_text_switched-3476515-2.patch605 bytes

Added patch to switch labels of button

jparmar’s picture

jparmar commented
Status: Active » Needs review
simohell’s picture

simohell commented
Status: Needs review » Needs work

On it's own the patch works, but in the big picture it seems that actually the titles are correct and links are switched, so this is not the correct fix.

Why I say the text is correct is, that both Group Node and Group Media first show "relate" (add) first and "create" (create) second. And I very much think we should keep the same order to be consistent. Switching the route names instead ot the titles should work fine.

  • lobsterr committed d842d58d on 3.x 
    feat: #3476515 "Relate block" and "Create block" button text switched?...
lobsterr’s picture

lobsterr commented
Status: Needs work » Fixed

Thank you for your contribution

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.