Problem/Motivation

phpstan step does not run successfully.

Steps to reproduce

Open https://git.drupalcode.org/project/field_formatter_class/-/pipelines to see the red flags. ;-)

Issue fork field_formatter_class-3476292

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tobiasb created an issue. See original summary.

tobiasb opened merge request !9

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Assigned: tobiasb » Unassigned
Status: Active » Needs review
jannakha’s picture

jannakha commented
Status: Needs review » Needs work

liuyuanchao made their first commit to this issue’s fork.

liuyuanchao’s picture

liuyuanchao commented
Status: Needs work » Reviewed & tested by the community

The phpstan pipelines work without warnings,
change this to RTBC.

https://git.drupalcode.org/issue/field_formatter_class-3476292/-/pipelin...

jannakha’s picture

jannakha commented
Status: Reviewed & tested by the community » Needs review

Code needs to be reviewed by someone who has not committed to MR.

This issue has to be tested as well.

paraderojether’s picture

paraderojether commented

Hi

I reviewed MR!9, and confirmed phpstan is now passed on Gitlab CI.

Moving this to RBTC!
Thank you.

paraderojether’s picture

paraderojether commented
Status: Needs review » Reviewed & tested by the community

vladimiraus made their first commit to this issue’s fork.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed

Thank you for your contributions! 🍻
Merged. 🦘

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.