Problem/Motivation

The $modules property in the MigrateFieldFormatterClassSettingsTest class is declared as public, which violates Drupal's coding standards and should be changed to protected.

Steps to reproduce

Review the deprecation status of the field_formatter_class module for Drupal 11.

Observe any issues or warnings related to deprecated code in the module.

Proposed resolution

Change the $modules property from public to protected in the MigrateFieldFormatterClassSettingsTest class.

Remaining tasks

  • Update the visibility of the $modules property.
  • Review and test the updated code.

Issue fork field_formatter_class-3472609

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yuvania created an issue. See original summary.

yuvania opened merge request !6

yuvania’s picture

yuvania
she/her
Primary language Spanish
commented
Issue summary: View changes
yuvania’s picture

yuvania
she/her
Primary language Spanish
commented
Issue summary: View changes
edwtorba’s picture

edwtorba commented

I have reviewed this and it complies with OOP principles.

edwtorba’s picture

edwtorba commented
Status: Active » Reviewed & tested by the community
tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Assigned: yuvania » Unassigned
tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Title: Property Drupal​\​Tests​\​field_formatter_class​\​Kernel​\​Migrate​\​d7​\​MigrateFieldFormatterClassSettingsTest::$modules property must be protected. » Property $modules must be protected

vladimiraus made their first commit to this issue’s fork.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Thank you for your contributions! 🍻
Merged. 🦘

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.