Problem/Motivation

  1. On the click of 'Generate token' redirects to a window
  2. On the click of 'Copy' ajax throbber comes and nothing happens
  3. On the click of 'Delete' ajax throbber comes and table doesn't get updated but token gets deleted which can be seen on detail token page or on same page after refresh
  4. On the click of 'Renew' ajax throbber comes and table doesn't get updated but token gets renewed which can be seen on detail token page or on same page after refresh

Steps to reproduce

  1. composer require 'drupal/access_unpublished:^1.16'
  2. drush en access_unpublished
  3. create two unpublished nodes i.e node1(Article) & node2(Basic page)
  4. edit node 2 and add below html to body field with 'Full Format' Editor and hit save
  5. <a href="/node/1/edit" class="use-ajax" data-dialog-type="modal" data-dialog-options='{"width":700}'>Edit node 1 in modal</a>
  6. do drush cr (if modal not opens)
  7. now view node2 you will see the link you created in step#4 & #5, click on it you will get the form in modal
  8. try using any of the module functionalities

Proposed resolution

Patch to fix

Remaining tasks

Contribute patch

CommentFileSizeAuthor
img2.png339.52 KBakshay.singh
img1.png233.95 KBakshay.singh
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

akshay.singh created an issue. See original summary.

akshay.singh’s picture

Title: Generate token not working inside entity browser modal » Module not functional inside modal or entity browser
akshay.singh’s picture

Issue summary: View changes

Issue description updated to more simpler STR in order to check and fix the issue.

akshay.singh’s picture

Assigned: Unassigned » akshay.singh

WIP

akshay.singh’s picture

Assigned: akshay.singh » Unassigned
Status: Active » Needs review

Ready for review

chr.fritsch’s picture

Status: Needs review » Needs work

Needs a rebase

akshay.singh’s picture

Status: Needs work » Needs review

mably made their first commit to this issue’s fork.

mably’s picture

Rebase done.

I have created a dedicated issue for the javascript clipboard copy upgrade part: #3560429: Upgrade clipboard copy javascript code.

Updated current MR to remove the corresponding javascript code.

mably’s picture

FYI the same problem has also been fixed in issue #3335950: Move Access Tokens UI to an entity Local Task / Tab.

The problem was that at each Ajax request it was duplicating the wrappers around the table element.