Overview

SEE MR FOR DETAILS

User interface changes

BEFORE FIX

AFTER FIX

CommentFileSizeAuthor
#7 Untitled.gif305.16 KBgauravvvv
#4 after-fix-slot.gif913.05 KBhooroomoo
#4 before-fix-slot.gif2.72 MBhooroomoo

Issue fork experience_builder-3473656

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hooroomoo created an issue. See original summary.

hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Title: Hovering on a slot in the layers menu throws disruptive console warnings due to incorrect logic » Hovering on a slot in the layers menu throws disruptive console warnings due to incorrect logic in Outline.tsx

hooroomoo opened merge request !299

hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Issue summary: View changes
StatusFileSize
new before-fix-slot.gif2.72 MB
new after-fix-slot.gif913.05 KB
hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Assigned: hooroomoo » Unassigned
Status: Active » Needs review
hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Issue summary: View changes
gauravvvv’s picture

gauravvvv commented
Status: Needs review » Needs work
StatusFileSize
new Untitled.gif305.16 KB

The hover issue has been fixed, but clicking the slot throws an error. please see the stack trace and GIF for reference.

Drupal\Core\Render\Component\Exception\ComponentNotFoundException: Unable to find component "experience_builder:druplicon" in the component repository. [The "experience_builder:druplicon" plugin does not exist. Valid plugin IDs for Drupal\Core\Theme\ComponentPluginManager are: experience_builder:deprecated, experience_builder:obsolete, experience_builder:experimental, experience_builder:my-section, experience_builder:shoe_tab_group, experience_builder:two_column, experience_builder:one_column, experience_builder:my-hero, experience_builder:image, experience_builder:shoe_tab, experience_builder:shoe_tab_panel, experience_builder:heading, experience_builder:shoe_badge, experience_builder:shoe_button, experience_builder:shoe_details, experience_builder:video, experience_builder:shoe_icon, olivero:teaser] in Drupal\Core\Theme\ComponentPluginManager->createInstance() (line 118 of /var/www/html/core/lib/Drupal/Core/Theme/ComponentPluginManager.php).

omkar-pd made their first commit to this issue’s fork.

omkar-pd’s picture

omkar-pd commented
Status: Needs work » Needs review

Pushed the latest changes, this should fix the issue. Please test again @gauravvvv.

jessebaker made their first commit to this issue’s fork.

  • jessebaker committed 9ea4a847 on 0.x authored by hooroomoo 
    Issue #3473656 by hooroomoo, omkar-pd, gauravvvv: Hovering on a slot in...
jessebaker’s picture

jessebaker commented
Status: Needs review » Fixed

Works for me. Someone can make a request to change the colour in a later issue if it's not right, the error is just too boring to leave in so I'm merging.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.