Problem/Motivation

The link field for media block is not showing up when editing or adding an inline media block

Steps to reproduce

When adding a media (image/video) block in Layout Builder
And selecting a media image type
Then the Link field is not showing up

Proposed resolution

  • Check the conditional form logic when building and rebuilding:
    • In the 2nd AJAX level and and after 3rd AJAX level
    • In some cases 3rd AJAX level and and after 4rd AJAX level

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ✅ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-10.1.0, varbase_layout_builder-10.2.0-rc1, varbase-10.0.9, varbase_layout_builder-10.1.17, varbase-9.1.13, varbase_layout_builder-10.0.67

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

Comments

ahmad abbad created an issue. See original summary.

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Thanks, Ahmad, for reporting.
I confirm the issue with Drupal 10.3.3 not sure if we had this issue with Drupal ~10.2.0 or ^10.3.1

rajab natshah’s picture

Project: Varbase Media » Varbase Layout Builder
rajab natshah’s picture

Varbase 10.0.x - Media (image/video) inline block

Varbase 10.0.x - On add but no media yet for the inline block.
Varbase 10.0.x - On add but no media yet for the inline block.

Varbase 10.0.x - when a media was added in the inline block
Varbase 10.0.x - when a media was added in the inline block

Varbase 10.0.x - when editing an inline block which had a media selected in it
Varbase 10.0.x - when editing an inline block which had a media selected in it


Varbase 9.1.x - Media (image/video) inline block

Varbase 9.1.x - On add but no media yet for the inline block.
Varbase 9.1.x - On add but no media yet for the inline block.

Varbase 9.1.x - when a media was added in the inline block
Varbase 9.1.x - when a media was added in the inline block

Varbase 9.1.x - when editing an inline block which had a media selected in it
Varbase 9.1.x - when editing an inline block which had a media selected in it

rajab natshah’s picture

Status: Active » Needs work
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Priority: Normal » Major
rajab natshah’s picture

Assigned: Unassigned » rajab natshah
Status: Needs work » Active
rajab natshah’s picture

Version: 10.0.x-dev » 10.2.x-dev

  • rajab natshah committed c63f4b3c on 10.2.x
    feat: #3473611 Fix no link field over media image in inline media block...

  • rajab natshah committed 7f23f88c on 10.1.x
    feat: #3473611 Fix no link field over media image in inline media block...

  • rajab natshah committed ef339968 on 10.0.x
    feat: #3473611 Fix no link field over media image in inline media block...
rajab natshah’s picture

Assigned: rajab natshah » mohammed j. razem
Status: Active » Needs review
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

Issue summary: View changes

✅ Release varbase-10.1.0

rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-9.1.13

rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-10.0.9