Problem/Motivation

There are several smaller details to note on admin/config/system/view-password-settings:

  • According to the Drupal interface standards it should be avoided to use the word please: https://www.drupal.org/docs/develop/user-interface-standards/interface-text
  • At the moment the title and description for each field is sort of redundant. You have instructional copy in the title and again within the description.
  • It is not clear based on the description what the purpose of the first two fields actually is. It clear you are able to add ids and classes there but the reason is sort of missing?

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork view_password-3473356

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rkoller created an issue. See original summary.

anacolautti made their first commit to this issue’s fork.

anacolautti’s picture

anacolautti commented

Hi again, thank you for your input here.

I created a branch to start these fixes.

  • Remove "Please" word from the form (2 found)
  • Change form labels
  • Improve the field descriptions

These are the proposed changes so far:

Current text Proposed new text
Enter the form id(s) here. Form id(s)
Please enter the form id(s) by separating it with a comma (make sure there are no spaces between form ids). For example, the usual form ids are user_login_form and user_register_form. . Enter the form ids machine names, separatied with commas (make sure there are no spaces between form ids). For example, the usual form ids are user_login_form and user_register_form, and they should be entered like user_login_form,user_register_form.
Enter the form class here. Icon CSS classes
Please enter the icon span classes separated with a space. If needed, you can enter CSS classes to apply to the span html element that contains the icon. Separate multiple classes with a space.
Enter the path to the SVG icon here that represents a hidden password. Path to the SVG icon File for the hidden password
Enter a relative path to your project's root folder, with a trailing /, like "/themes/custom/my_theme/my_icon.svg" (defaults to [icon]). Would not change this.
Enter the path to the SVG icon here that represents an exposed password. Path to the SVG icon File for the exposed password
Enter a relative path to your project's root folder, with a trailing /, like "/themes/custom/my_theme/my_icon.svg" (defaults to [icon]). Would not change this.

I'd also update the validation message for the Form id(s) field to be:

The <em>Form id(s)</em> field should contain values separated by commas only. Spaces or new lines are not allowed.

anacolautti opened merge request !26

  • anacolautti committed 93a31bef on 6.0.x 
    Issue #3473356 by anacolautti, rkoller: Improve the microcopy on the...
anacolautti’s picture

anacolautti commented
Status: Active » Fixed

I merged and closed this because there was no feedback against it. Thanks @rkoller for the ticket.

anacolautti’s picture

anacolautti commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.