GitLab CI reports PHP_CodeSniffer errors/warnings which should be fixed.

Issue fork ai_image_alt_text-3472717

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sunil jolapara created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Fix the PHP_CodeSniffer issues » Fix the issues reported by PHP_CodeSniffer
Status: Needs work » Active

avpaderno opened merge request !2

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Anonymous’s picture

Anonymous (not verified) commented
Assigned: Unassigned »
Anonymous’s picture

Anonymous (not verified) commented

Rebasing to get the latest changes, Will solve the remaining PHPCS warnings

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review

Solved all the PHPCS errors
Also solved the cspell error

PHPCS and cspell pipelines are all green
Moving to needs review

Anonymous’s picture

Anonymous (not verified) commented
Assigned: » Unassigned
a.aaronjake’s picture

a.aaronjake commented
Assigned: Unassigned » a.aaronjake
a.aaronjake’s picture

a.aaronjake commented
Assigned: a.aaronjake » Unassigned
Status: Needs review » Reviewed & tested by the community

Hi @akulsaxena,

I have checked the pipeline and re-ran the phpcs and cspell jobs and confirmed the jobs succeeded.

Will now move this to RTBC.

Thanks,
Jake

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Needs work
Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review

I made the changes as suggested but the PHPCS pipeline is failing with the error:
Parameter $file has null default value, but is not marked as nullable.(SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing)
Thus, I think it needs to be made nullable according to GitLab CI.
Thus reverting it back to the original change and setting $file back to nullable.
The PHPCS pipeline is now green

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

The merge request fixes all the reported PHP_CodeSniffer errors/warnings.

a.aaronjake’s picture

a.aaronjake commented
Status: Needs review » Reviewed & tested by the community

Hi @akulsaxena & @avpaderno,

I have checked the pipeline and confirmed the phpcs are updated according to the suggestions. I have also re-ran the phpcs job and confirmed it succeeded.

Will now move this to RTBC.

Thanks,
Jake

marcus_johansson’s picture

marcus_johansson commented
Status: Reviewed & tested by the community » Fixed

Thank you everyone, this is getting merged into dev and the next release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.