Overview

The component insert panel displays a potentially long list of components to choose from and add to the content. We need to ensure that this list is scrollable in order to access all components.

Component insert panel

Proposed resolution

Write an end-to-end test to make sure that the component insert panel is scrollable. With our canvas and preview logic where we listen to all kinds of mouse events, it's easy to introduce a bug that impacts scrollable areas. Let's make sure it doesn't happen anymore!

It's probably a good idea to test this in a standalone test case and stub the HTTP request which returns the list of components, so we can be sure we have enough components for the scroll to be necessary.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

balintbrews created an issue. See original summary.

omkar-pd’s picture

Assigned: Unassigned » omkar-pd
Issue tags: -JavaScript +JavaScript

omkar-pd’s picture

Assigned: omkar-pd » Unassigned
Status: Active » Needs review
Issue tags: -JavaScript +JavaScript
omkar-pd’s picture

Tests passed.

wim leers’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs tests

LGTM — but needs final sign-off from one of the /ui owners 😊

balintbrews’s picture

Status: Reviewed & tested by the community » Fixed

This is really nice, thank you, @omkar-pd! 🎉

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.