Overview

Clicking the + button in the top-left corner shows the component list. This list is not scrollable.

Component list

This issue was discovered in #3454125-53: Implement temporary design system for the DrupalCon Barcelona demo (see 1.3), then it was added in #3463798-10: No upward auto-scroll when components are dragged, from where it was moved to being its own issue, so other changes are not blocking it. It's in the critical path for #3454094: Milestone 0.1.0: Experience Builder Demo.

Proposed resolution

The problem is twofold:

  1. There is unnecessary code in an event handler that takes over the scroll event;
  2. The container that lists components doesn't allow content to overflow.

User interface changes

A component list that scrolls.

CommentFileSizeAuthor
#3 xb-component-list-scroll.gif9.55 MBbalintbrews
xb-unable-to-scroll-component-list.jpg93.52 KBbalintbrews

Issue fork experience_builder-3471102

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

balintbrews created an issue. See original summary.

balintbrews opened merge request !228

balintbrews’s picture

balintbrews
he/him/his
Primary language Hungarian
Location Netherlands 🇪🇺
commented
Assigned: balintbrews » bnjmnm
Status: Active » Needs review
StatusFileSize
new xb-component-list-scroll.gif9.55 MB

Scrolling component list

balintbrews’s picture

balintbrews
he/him/his
Primary language Hungarian
Location Netherlands 🇪🇺
commented

@kristen pol, I fixed the broken preview thumbnails you noticed in #3463798: No upward auto-scroll when components are dragged.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

This is working for me! Yay! So much easier :)

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
Parent issue: » #3450592: [META] Front-end Kanban issue tracker
Related issues: +#3463798: No upward auto-scroll when components are dragged, +#3454125: Implement temporary design system for the DrupalCon Barcelona demo

Looks great! 😄

Signaling to Ben how close to ready this is :)

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Assigned: bnjmnm » balintbrews
Status: Reviewed & tested by the community » Needs work

@balintbrews I have only one bit that needs looking at - could you either remove the style change in the (i think) unused class or explain where it is used?
After that just switch back to RTBC and I'll commit.

balintbrews’s picture

balintbrews
he/him/his
Primary language Hungarian
Location Netherlands 🇪🇺
commented
Assigned: balintbrews » bnjmnm
Status: Needs work » Reviewed & tested by the community

Thanks for the review, @bnjmnm!

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Assigned: bnjmnm » Unassigned
Status: Reviewed & tested by the community » Fixed

Good stuff! Merged.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Yay! 😍

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.