Enable GitLab CI automated testing.

Issue fork wxt-3472183

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

liam morland created an issue. See original summary.

liam morland opened merge request !19

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Active » Needs review

This merge request sets up coding standards testing.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Some of the linting issues it finds are in libraries installed in html/libraries. It shouldn't be checking these because they are not part of this repository. It also raises spelling issues about a couple of words that are in the unrecognized words list.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Nice

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 5.2.x-dev » 5.3.x-dev
Assigned: Unassigned » liam morland
Status: Needs review » Fixed
smulvih2’s picture

smulvih2
Location Canada 🍁
commented

This looks good now, GitLab tests are all passing. Pushed out a dev release for 5.3.x with this included - https://www.drupal.org/project/wxt/releases/5.3.x-dev

smulvih2’s picture

smulvih2
Location Canada 🍁
commented

Adding attribution for Liam for the great work!

liam morland opened merge request !20

  • liam morland committed 3b505394 on 5.3.x 
    Issue #3472183: Ignore useless method overriding on ArchivedField::...
smulvih2’s picture

smulvih2
Location Canada 🍁
commented

Tested a fresh install, works great! Nice to see the GitLab CI all green! Also ran WxT migrations and all is working as expected.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.