GitLab CI reports PHP_CodeSniffer errors/warnings which should be fixed.

Issue fork bootstrap_datetime_picker-3471965

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sunil jolapara created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Drupal Coding Standard is not matched » Fix the issues reported by PHP_CodeSniffer
Category: Bug report » Task
Status: Needs work » Active
Issue tags: -Drupal coding standard checks

avpaderno opened merge request !9

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Anonymous’s picture

Anonymous (not verified) commented
Assigned: Unassigned »
Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review

I fixed the PHPCS errors and the PHPCS pipeline is now green.
Please review

Anonymous’s picture

Anonymous (not verified) commented

Also, we need 3 more issues for other pipelines since the cspell, eslint and phpstan pipelines are also failing.

Anonymous’s picture

Anonymous (not verified) commented
Assigned: » Unassigned
a.aaronjake’s picture

a.aaronjake commented
Status: Needs review » Reviewed & tested by the community

Hi @akulsaxena,

I have checked and even re-ran the job and confirmed phpcs passed.

Will now move this to RTBC

Thanks,
Jake

sadashiv’s picture

sadashiv commented
Status: Reviewed & tested by the community » Fixed

Anonymous’s picture

Anonymous (not verified) commented

Hi @Sadashiv,

The issue has been resolved, marked as fixed, and the MR has been merged. However, issue credits have not been assigned to the developers who contributed to the fix. Issue credits play a crucial role in keeping contributors motivated to continue contributing to Drupal. Could you kindly look into this and assign the credits accordingly?

Thanks,
Akul

sadashiv’s picture

sadashiv commented

Assigning credits

sadashiv’s picture

sadashiv commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.