Problem/Motivation
We've noticed that the Hybrid Login block displays a header at the bottom of the custom block template:
{% if hide_drupal_login == 0 %}
<hr>
<h2>Sign in with existing account</h2>
{% endif %}
This made sense at first when you have a vertical layout for the Drupal login page, but if a site wanted a horizontal split layout it wouldn't display correctly. This title probably shouldn't be managed in this block, but rather in a login form template outside of the Hybrid Login module.
Steps to reproduce
- If you move the Drupal login form to a different part of the page, the "Sign in with existing account" title does not follow that form because it is not part of the form, but rather part of the Hybrid Login block (it shouldn't)
Proposed resolution
Simply remove the code snippet above from the template file located in templates/hybrid-login-block.html.twig
Issue fork hybrid_login-3471874
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
majorrobot commentedHey @jminarick, this makes sense. Better to let the theme / individual site owner decide how to deal with that header. Looks good.
Comment #4
jminarick commentedComment #5
jminarick commented