GitLab CI reports PHP_CodeSniffer errors/warnings which should be fixed.

Issue fork user_bulk_delete-3471572

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sunil jolapara created an issue. See original summary.

rajesh bhimani’s picture

rajesh bhimani commented
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Drupal Coding Standard is not matched » Fix the issues reported by PHP_CodeSniffer
Category: Bug report » Task
Status: Needs work » Active
Issue tags: -Drupal coding standard checks

avpaderno opened merge request !2

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
chhavi.sharma’s picture

chhavi.sharma commented
Assigned: Unassigned » chhavi.sharma

Working on it.

chhavi.sharma’s picture

chhavi.sharma commented
Assigned: chhavi.sharma » Unassigned
Status: Active » Needs review

Made phpcs pipeline green. Please review.

avpaderno opened merge request !3

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes

avpaderno changed the visibility of the branch 3471572-gitlab-ci-reports to hidden.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Normal » Minor
paraderojether’s picture

paraderojether commented
Status: Needs review » Reviewed & tested by the community

Hi

I reviewed MR!2, applied it against Users Bulk Delete, and confirmed phpcs are now fixed.

Code Sniffer

➜  user_bulk_delete git:(main) ✗ curl https://git.drupalcode.org/project/user_bulk_delete/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2693    0  2693    0     0   9171      0 --:--:-- --:--:-- --:--:--  9318
patching file .gitlab-ci.yml
patching file user_bulk_delete.install
patching file user_bulk_delete.module
➜  user_bulk_delete git:(main) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig user_bulk_delete
➜  contrib git:(main) ✗

It also passed on the Gitlab CI.

Moving this to RTBC!
Thank you.

pilot3’s picture

pilot3 commented

+1 confirmed phpcs errors are now fixed.

chaitanyadessai’s picture

chaitanyadessai commented
Status: Reviewed & tested by the community » Fixed

Merged, thanks.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.