Updates to be compatible with Drush 12 and 13.

Support for Drupal 8/9 is dropped. Those are long since EOL.

Issue fork pathauto-3471063

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

moshe weitzman created an issue. See original summary.

moshe weitzman opened merge request !89

sokru made their first commit to this issue’s fork.

sokru changed the visibility of the branch 3471063-modernize-drush-commands to hidden.

sokru’s picture

sokru commented
Status: Needs review » Reviewed & tested by the community

Fixed small lint issue on composer.json. Setting status RTBC and leaving up to maintainers to choose if they want to support D9/Drush11.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Needs work

This has multiple conflicts and needs a rebase.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Should also fix the all all reported by #3502207: Wrong Drush command example, uses all all

ressa made their first commit to this issue’s fork.

ressa’s picture

ressa
he/him
commented

Great catch @berdir, and suggesting that it should be fixed here. I updated the MR.

liuyuanchao made their first commit to this issue’s fork.

liuyuanchao’s picture

liuyuanchao commented
Status: Needs work » Needs review

Solved the conflicts.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Merged, thanks.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

ressa’s picture

ressa
he/him
commented

Thanks @berdir!

Even with the very prominent entry under the comments, granting credit is often missed ... I wonder how we can improve the workflow, to make sure module maintainers remember this last, but crucial part of the process?

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

As you can see on the commit message, I configured credits, I just hadn't saved them. I think the UI needs better feedback on whether or not the credits have been saved or not. Maybe a warning message similar to various drag and drop interfaces or possibly even make the commit message only visible after you safe, so you can't miss it.

I don't think the reminder in the issue helps, because I don't look at that anymore after it's merged and closed, credits need to be configured and set before closing due to the commit message.

ressa’s picture

ressa
he/him
commented

Thanks for the feedback @berdir, and your great suggestions for improvement. Based on them, I created #3546523: Improve UI feedback on the credit page (Contribution record).
Like I commented in that issue the credit reminder email may also not work, and just get deleted ...

And thanks for pointing out that the crediting was actually "half-way there", and can be seen in the commit message. I was wondering what "By: sokru ... By: moshe weitzman..." was all about :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.