The Color Scheme Field contains a field that allows to choose between color schemes defined in the default theme. You'd add your schemes in the info yml like 

color_scheme:
  scheme-one: Scheme one
  scheme-two: Scheme two

and this field would pick that up and present the options. Once a value is selected it would be the themes responsabillity further.

Project link

https://www.drupal.org/project/color_scheme_field

Comments

andras_szilagyi created an issue. See original summary.

vishal.kadam’s picture

vishal.kadam
Location Mumbai
commented

Thank you for applying!

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

  • If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
  • For the time this application is open, only your commits are allowed.
  • The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
  • We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.

The important notes are the following.

  • It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
  • Reviewers should show the output of a CLI tool only once per application.
  • It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.

vishal.kadam’s picture

vishal.kadam
Location Mumbai
commented
Title: [1.x] Color Scheme Field. » [1.x] Color Scheme Field
Issue summary: View changes
rushikesh raval’s picture

rushikesh raval commented
Priority: Normal » Minor

as per me there is not enough PHP code to review code. Code reviewer will give inputs on this issue.

The code is used to verify what the users who apply understand about writing Drupal code. It's not possible to understand that when the project contains few code lines

Please Refer Ensure the branch used for the application contains enough PHP code

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
rushikesh raval’s picture

rushikesh raval commented

This thread has been idle, in the needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application. If you are no longer pursuing this application then You mark it as Closed (won't fix).

If this is incorrect, and you are still pursuing this application, then please feel free to set the issue status to Needs work or Needs review, depending on the current status of your code.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Closed (won't fix)

This thread has been idle, in the Needs work state with no activity for more than eight months; the application has been created more than 11 months ago. Therefore, I marked it as Closed (won't fix).

If this is incorrect, and you are still pursuing this application, please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.