You can currently drag components from the Desktop view into the mobile view. As far as I understand these should just be mirrors of each other at different screensizes, not seperate displays. We should stop this from being possible.
Not yet tested, but I believe if we give the desktop & mobile views seperate Sortable groups, we should be able to limit them so components can only be dragged from the Sidebar.
It will no longer be possible to drag components between mobile and desktop
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | Untitled.gif | 558.82 KB | gauravvvv |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
danielvezaComment #3
gauravvvv commentedComment #5
gauravvvv commentedComment #6
gauravvvv commentedHere is after MR gif
Comment #7
gauravvvv commentedComment #8
lauriiiThank you @gauravvvv! I'm wondering if this is something you could write a test for?
Comment #9
wim leersHAH! 😅
Comment #10
danielvezaNice! I'm glad my suggested approach was correct
Comment #12
wim leers@jessebaker reported the same bug at #3472064: It should not be possible to drag a component from one preview into the other. Closed that as a duplicate.
Comment #13
wim leersComment #15
omkar-pd commentedComment #17
utkarsh_33 commentedThis still requires tests as mentioned in #8. Marking it needs work.
Comment #18
jessebaker commentedComment #19
jessebaker commentedRemoving the need for tests - it's not, at this point, feasible to add reliable drag and drop tests. Especially a test that ensures you can't drag and drop! That just seems to be asking for a false positive!
That said, the codebase has changed significantly since this MR. I think it must have been made before the overlay solution even.
Comment #20
lauriii#3512455: Implement new drag-and-drop solution that removes the need to drop items into the preview iFrame has landed.
Comment #21
jessebaker commentedPostponing based on product/design clarification: We might not need to do this work as I have seen plans that remove the multiple simultaneous breakpoint previews (which would immediately mean this bug isn't possible).
Comment #22
wim leers@lauriii: has this been decided by now? 🤞
Comment #23
lauriiiThis won't be needed anymore after: #3522209: Move zoom controls, show only one viewport.