Using BEF filters in combination with remembered input clears the query parameters but not the remembered filter inputs.
Install newest BEF (7.0.0) with core (10.3.2) and create a few that has both BEF enabled and remembered filter inputs.
When clicking the reset button the query parameters are cleared but the remembered inputs remain.
Created a patch based on how the core reset (See: ExposedFormPluginBase::rememberForm()) works. This seems to resolve the issue but is untested otherwise.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | better_exposed_filters-reset_remembered_input-4.patch | 1.05 KB | sander wemagine |
| better_exposed_filters-reset_remembered_input.patch | 1.1 KB | sander wemagine |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
smustgrave commentedFix should be in an MR for tests to run.
Also would be good to get simple test coverage
Comment #3
vermario commentedthe same happens with 6.0.6 and drupal 10.2.7
Comment #4
sander wemagine commentedI don't know how to create a MR, anyone else want to create one or explain how to create one?
Comment #5
sander wemagine commentedI created a new patch. The previous patch couldn't apply to the latest 7.x branch anymore. This one does apply again.
Comment #7
smustgrave commentedCan't seem to get the test right but will try again later.
Comment #8
smustgrave commentedComment #9
smustgrave commentedFinally got the tests working minus random previous minor failure.
Comment #10
smustgrave commentedThink this still needs work as the tests are showing problems.
Comment #11
smustgrave commentedFINALLY figured it out.