Closed (fixed)
Project:
Web Experience Toolkit
Version:
5.3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
20 Aug 2024 at 18:41 UTC
Updated:
18 Nov 2024 at 01:29 UTC
Jump to comment: Most recent
Comments
Comment #2
smulvih2Found an issue with CKEditor5. When creating/editing a page, if you switch to the
Rich Text (CKEditor5)text format, you get an error in the console and the editor fails to initialize:Comment #3
smulvih2Drupal 10.3.x upgraded CKE5 from
41.2.0to41.3.1, which introduced a breaking change. CKEditor has renamed an export inckeditor5/src/uifromModeltoViewModel. This was causing a JS error in the console, and CKE5 was completely not usable. I pushed a commit to the 10.3.x branch to fix this - https://github.com/drupalwxt/wxt/commit/60bf7ea0d903a7f9f2776a8bb747c7158d880eacI have tested both the alert and panel CKE5 widgets and they work as expected now, and CKE5 is usable again.
Comment #4
joseph.olstadGreat, makes me wonder if ck4 still usable?
Comment #5
smulvih2Yes CKE4 is still usable, no breaking changes for CKE4.
Comment #6
smulvih2Updated a drupal/core patch after getting an error when running a migration:
The latest core MR/patch on that ticket resolves the issue. Change to patch here - https://github.com/drupalwxt/wxt/commit/7c77b699b51dfb20a48109621fb65c4f21f3e6dd
Comment #7
smulvih2Found an issue - the CKE5 text format forms throw errors when saved (even with no changes).
If I update drupal/footnotes from 3.1.0 to 4.0.0-beat5 it fixes the first three lines, but breaks the icon bar. Will have to look at each module providing these settings. Looks like these keys need to be added to the associated *.schema.yml files.
Comment #8
smulvih2Fixed 7 issues from the list above by adding the required schema.yml file to wxt_ext_editor for the filter plugin - https://github.com/drupalwxt/wxt/commit/b805b5ea2e688dd0124fa149dba3121636cc7061
Comment #9
smulvih2Fixed the remaining key errors by updating footnotes, toc_filter, and url_embed modules - https://github.com/drupalwxt/wxt/commit/bf65e073951d4c683301407df0c2a952af983250
Comment #10
smulvih2Fixed the remaining issues with the CKE5 text formats - https://github.com/drupalwxt/wxt/commit/de00a206f1b7266917844d7fb6f8dd98977b5867
I'm now able to edit the text formats and save them without error.
Comment #11
joseph.olstadVery nice, so how many ck5 text formats are there? I see you fixed it for rich text ck5, what about full html ck5? does that need it also?
Comment #12
joseph.olstadThis one likely also needs the fixes:
https://github.com/drupalwxt/wxt/blob/5.3.x/modules/custom/wxt_ext/wxt_e...
Comment #13
smulvih2No that other CKE5 text format doesn't use footnotes, nor does it have the
<drupal-entity>config for allow list.Comment #14
smulvih2A new dev release 5.3.x has been created for the Drupal core 10.3.x upgrade. I have been testing this upgrade in a large project for the last month and have fixed all issues identified.
Setting this to RTBC until @sylus does an official release.
Comment #15
joseph.olstadI think 5.3.x is close to being ready for 5.3.0 to be tagged?
A client has been using 5.3.x in production for a few weeks now and the upgrade process was fairly straight forward!
Comment #16
sylus commentedThanks so much @joseph.olstad and @smulvih2 for doing all the work pushed this out tonight :)