Problem/Motivation

After updating to Core 10.3 and when running a cron job to import feeds, got the TypeError "Argument #6 ($logger) must be of type Drupal\Core\Logger\LoggerChannelInterface, Psr\Log\NullLogger given in Drupal\feeds\FeedsQueueExecutable->__construct()".

Steps to reproduce

Update Drupal Core to v10.3.1 and Feeds to v8.0-3.0-beta5, start the cron job in Drupal UI.

Proposed resolution

One way to fix this is to relax the type hint to Psr\Log\LoggerInterface.

CommentFileSizeAuthor
#2 3468219-1.patch1.71 KBkevin w

Issue fork feeds-3468219

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Kevin W created an issue. See original summary.

kevin w’s picture

kevin w commented
StatusFileSize
new 3468219-1.patch1.71 KB

Add a patch

megachriz’s picture

megachriz
Primary language Dutch
commented

@Kevin W
Thanks for contributing code! Can you perhaps provide your code in a merge request instead? This way, the testbot would evaluate your code changes. Recently, the testbot on drupal.org only runs on merge requests and no longer on patches. This is related to the migration towards GitLab. Patches are still valuable, but a merge request is now better.

megachriz opened merge request !188

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Active » Needs review

  • megachriz committed 5f2fe3ae on 8.x-3.x 
    Issue #3468219 by megachriz, Kevin W: Fixed TypeError in...
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

Merged!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.