Overview

Trying to click and drag a component that is in a slot drags the parent component instead of the child you are clicking on,

Proposed resolution

When clicking and dragging via the preview the drag target should always be the innermost item, not any of its parents.

CommentFileSizeAuthor
#7 fix nested drag.gif1.02 MBhooroomoo
2024-08-14 11.32.18.gif253.79 KBjessebaker

Issue fork experience_builder-3468049

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jessebaker created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#3446722: Introduce an example set of representative SDC components; transition from "component list" to "component tree"

Visible since #3446722: Introduce an example set of representative SDC components; transition from "component list" to "component tree".

Are tests feasible or overkill? 🤔 AFAIK hover/drag/drop-related things are hard to tests. And this is obviously broken, so any regression on this front would be quickly found anyway?

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Title: Cannot drag child components, it drags the parent instead » Cannot place or drag child components

hooroomoo made their first commit to this issue’s fork.

hooroomoo opened merge request !181

hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Assigned: jessebaker » hooroomoo
hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Assigned: hooroomoo » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new fix nested drag.gif1.02 MB

Added gif to issue summary

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » jessebaker
Status: Needs review » Reviewed & tested by the community

Final sign-off from @jessebaker or @bnjmnm is needed. Asking @jessebaker because he previously reviewed this already.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Parent issue: » #3450592: [META] Front-end Kanban issue tracker
Related issues: +#3469442: Impossible to drop a component into an empty column of the two

P.S.: this allowed me to discover a new bug: #3469442: Impossible to drop a component into an empty column of the two. 😅

  • jessebaker committed 5c68207d on 0.x authored by hooroomoo 
    Issue #3468049 by hooroomoo, jessebaker, Wim Leers: Cannot place or drag...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: jessebaker » Unassigned
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.