We shouldn't put LIMIT directly into SQL since that's not always portable. We should be using db_query_range(), instead. This is one of the last things pcorbett was trying to accomplish with a monolithic patch over at #170935: Patch for some new functions I added as well as some updates to existing ones which hasn't already been resolved.

CommentFileSizeAuthor
#1 346784_db_query_range.1.d5.patch2.91 KBdww
#1 346784_db_query_range.1.d6.patch1.8 KBdww

Comments

dww’s picture

dww
we/he/they
commented
Assigned: Unassigned » dww
Status: Active » Needs review
StatusFileSize
new 346784_db_query_range.1.d6.patch1.8 KB
new 346784_db_query_range.1.d5.patch2.91 KB

(Untested, but this should do it).

dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed

I tested. dmitrig01 liked the code. Committed to DRUPAL-6--1 and DRUPAL-5--2.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.