Problem/Motivation

I was expecting to find the CSV exporting functionality from this module. And I did, it just wasn't functional at all and was disabled. After finding two issues (#2621210: D8+: Export vocabulary functionality, #2960782: "Export" button is non-functional) I realized that no one has done this for D8+ so I thought to file a ticket to get this implemented.

I know this could be done i.e. with views_data_export module, but I need one place for site editors to be able to to some term management, and this module seemed suitable and actually did contain the stub of the feature.

Proposed resolution

Complete the implementation for the CSV export and de-disable the form button.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jhuhta created an issue. See original summary.

jhuhta’s picture

Assigned: jhuhta » Unassigned
Status: Active » Needs review
sokru’s picture

Status: Needs review » Reviewed & tested by the community

Looks good! It doesn't include the automated tests, but those could be added on separate issue.

VladimirAus changed the visibility of the branch 3467144-csv-export-functionality to hidden.

vladimiraus’s picture

Status: Reviewed & tested by the community » Needs work

The conflcit with 2.x needs to be resolved. Cheers

jhuhta’s picture

Status: Needs work » Needs review
sokru’s picture

Status: Needs review » Reviewed & tested by the community

Resolved the PHPCS issues, caused by other issues merged after PHPCS issue.

I've tested this manually to be working.

I created a separate issue for resolving PHPStan issues #3467558: Resolve PHPHStan issues.

  • vladimiraus committed c3d48d21 on 2.0.x authored by jhuhta
    Issue #3467144 by jhuhta, sokru, vladimiraus: CSV export functionality
    
vladimiraus’s picture

Status: Reviewed & tested by the community » Fixed

Thank you! Committed! 🍻

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.