Problem/Motivation

The merged changes from Issue #3453956 result in the table drag handle being misaligned when it is collapsed or while editing. I think some other css changes from the last release make those changes obsolete.
It's not aligned with the text anymore. The focus does also not look correct.

Paragraphs 1.17:
Paragraphs tabledrag handle in 1.17
Paragraphs 1.18:
Paragraphs tabledrag handle in 1.17
Focus in 1.18:
paragraph dragtable handle focus

I tested it with Drupal 10.3.1/10.3.2 and Paragraph 1.18. Claro is used as the backend theme.

Proposed resolution

Revert the changes from the related issue.

CommentFileSizeAuthor
#10 3467124-tabledrag-handle-is-misaligned-10.patch1.37 KBlobodakyrylo
#8 Monosnap Edit Builder page Laser Marking and Engraving Machines for Metals | Laserax 2025-01-02 17-22-47.png671.28 KBlobodakyrylo
#6 Screenshot 2024-08-21 at 9.08.33.png41.28 KByevko
paragraphs_before.PNG1 KBlmoeni
paragraph_drag_drop_focus.PNG8.02 KBlmoeni
paragraphs_1-18_3453956.PNG30.19 KBlmoeni

Issue fork paragraphs-3467124

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lmoeni created an issue. See original summary.

lmoeni’s picture

lmoeni
she/her
commented
Issue summary: View changes

lmoeni opened merge request !137

lmoeni’s picture

lmoeni
she/her
commented
Status: Active » Needs review
lmoeni’s picture

lmoeni
she/her
commented
Issue summary: View changes
yevko’s picture

yevko commented
StatusFileSize
new Screenshot 2024-08-21 at 9.08.33.png41.28 KB

Tested and works well!

after patch

For 10.3.2 as well

Only local images are allowed.

neclimdul’s picture

neclimdul
He/Him
commented
Status: Needs review » Reviewed & tested by the community

This also fixed the tabledrag in 10.3 for us as well.

It seems to revert the previous issue but I thought the centering was an improvement so that's fine with me.

lobodakyrylo’s picture

lobodakyrylo commented
StatusFileSize
new Monosnap Edit Builder page Laser Marking and Engraving Machines for Metals | Laserax 2025-01-02 17-22-47.png671.28 KB

It doesn't work for 10.4 and the Claro theme because of this element:

lobodakyrylo’s picture

lobodakyrylo commented
Status: Reviewed & tested by the community » Needs work
lobodakyrylo’s picture

lobodakyrylo commented
StatusFileSize
new 3467124-tabledrag-handle-is-misaligned-10.patch1.37 KB

I don't know what's the purpose of that .handle element, but I temporary hid it and this patch works for me.

hosterholz made their first commit to this issue’s fork.

hosterholz opened merge request !227

neclimdul’s picture

neclimdul
He/Him
commented
Status: Needs work » Reviewed & tested by the community

lgtm. new MR is essentially a rebase of the older MR so all good.

idebr’s picture

idebr commented
Version: 8.x-1.18 » 8.x-1.x-dev

berdir made their first commit to this issue’s fork.

  • berdir committed 4fcd76e6 on 8.x-1.x authored by hosterholz 
    fix: #3467124 Tabledrag handle is misaligned

By: lmoeni
By: neclimdul...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Merging. Looks like the change from #10 is not included, maybe that's in combination with something else or a different widget or something? Please create a separate issue.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.