Problem/Motivation

When using the gin admin theme the confirmation dialog for node state change. Clicking yes to confirm change throws a JS error and the dialog isnot closed and the node form is not submitted

Steps to reproduce

  • with the gin admin theme enabled
  • enable the dialog on node edit form
  • edit a node change state from draft to published
  • confirm "yes" to publish

Proposed resolution

The target classes for triggering the submit don't match with those on the gin theme, we can target the gin classes

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3466902-01.patch1.11 KBgavin.hughes

Comments

gavin.hughes created an issue. See original summary.

gavin.hughes’s picture

gavin.hughes commented
StatusFileSize
new 3466902-01.patch1.11 KB

I can see this is addressed in the 3.0 release see but it may be useful for those not yet on the new release https://git.drupalcode.org/project/moderated_content_bulk_publish/-/comm...

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

this was merged a while ago, I'll give you credit.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Version: 2.0.32 » 2.0.37
Status: Active » Fixed

With that said, I have another gin improvement to make.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

you'll likely want 2.0.38

#3546871: Prevent form anomalies from resulting in multiple confirm dialogs

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Version: 2.0.37 » 2.0.38

if you're on 2.0.x like me, I recommend 2.0.38 or newer 2.0.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.