Problem/Motivation
Test submit form is submitting the form values incorrectly to the firebase api service.
Steps to reproduce
Get FCM token that is valid.
Create test notification on test form and submit.
Will return error.
Proposed resolution
Update
$this->messagingService->sendMessageSingleDevice(
$form_state->getValue('title'),
$form_state->getValue('message'),
$form_state->getValue('device_token'),
NULL,
NULL,
NULL,
intval($form_state->getValue('badge_count')),
);
to
$this->messagingService->sendMessageSingleDevice(
$form_state->getValue('device_token'),
$form_state->getValue('title'),
$form_state->getValue('message'),
NULL,
NULL,
NULL,
intval($form_state->getValue('badge_count')),
);
Remaining tasks
Update code as above.
User interface changes
API changes
Data model changes
Comments
Comment #4
ptmkenny commentedComment #6
ptmkenny commentedThanks for reporting this. You're absolutely right; the arguments got switched around.
Comment #8
webflo commentedCan we get a new release for the project? It has caused me a lot of problems when using the module. Unfortunately, everything was configured correctly, only the test mode was broken.
Great module! Thanks @ptmkenny
Comment #9
ptmkenny commented@webflo Done, and sorry about that. I had intended to do another release after fixing the bug and I got sidetracked.