| smustgrave |
sharing this on behalf of @Kristen Pol (she/her)https://drupal.slack.com/archives/C072JMEPUS1/p1722275858716919 |
| guptahemant |
To accelerate the work of demo design system we are working on an automation script more details in here https://drupal.slack.com/archives/C07CDLSD8UU/p1722431008045169 |
| smustgrave |
Nice! seems similar to what the ui_pattern team has developed cc @Pierre (pdureau) |
| smustgrave |
But with patterns |
| guptahemant |
Yes, this one is in python, and we are relying on twig comments and twig codebase to infer the SDC yaml mapping. More details are being added by my colleagues on[#3465043] (edited) |
| Pierre (pdureau) |
Looks nice to init the definition file, saving some time for the developer which will author the proper definition |
| smustgrave |
6️⃣ Weekly updates - What have you been working on? What’s up next? Need assistance with anything? Any blockers? |
| guptahemant |
I was trying out exp. builder with starshot prototype today to check integration with SDC components which are being created as part of #starshot-demo-design-system, and faced a couple of issues,From what i can see the exp. builder is not yet ready to test with SDC integration,is this understanding correct?If not, Looking for some guidance / recommendation on testing SDC components coming from a theme with exp. builder in its current state (edited) |
| Kristen Pol (she/her) |
Fast and furious doing #starshot-demo-design-system stuff… documentation, theme tweaks, onboarding, reviews, planning, creating more issues, etc :clipboard: |
| Gaurav mahlawat |
I am working on[#3463610]No blockers |
| Kristen Pol (she/her) |
Yes :raised_hands: it will super helpful and is much appreciated :heart_eyes: |
| lleber |
Will such conversion tools produce sustainable solutions? Design systems aren't a one and done thing, they're a living, breathing part of an organization or brand. Instead of the need to constantly chase the bleeding edge by re-transpiling non-SDC sources, I feel this speaks to the need of additional SDC* APIs. (edited) |
| Kristen Pol (she/her) |
SDC migration api would be cool |
| lleber |
I was thinking more along the lines of a deriver of sorts.$sdcs = whatever core does
alter(&$sdcs); // <-- plug whatever in here at compile time
I'd be hard pressed to abandon CMS-agnostics just to get back on an island again. (edited) |
| Kristen Pol (she/her) |
I see... so no need to create the metadata file but it just gets picked up using your code? |
| lleber |
Sort of an adapter layer that can be applied to existing design systems that have their own data formats. |
| lleber |
For example our metadata is stored in package.json files, which are a one-liner-ish from being automatically transformed to YML and/or data structures that Drupal can understand. |
| lleber |
If an SDC is broken down, it's just an array of data. Kind of weird that we can't alter that array with a Drupal API, isn't it? Just about every other subsystem can...for example, libraries. We transform our package.json data into Drupal libraries. |
| Kristen Pol (she/her) |
Yeah… we are adding SDC files but our UI kit is tech agnostic so I’m trying to see how to best implement this |
| lleber |
IIRC there was an API issue opened as such and subsequently closed as a wontfix. If memory serves it was over the concept of "single directory components shouldn't be allowed to indirectly exist in multiple directories" that such an API might expose.... |
| lleber |
https://www.drupal.org/project/drupal/issues/3346019#comment-14952407 |
| lleber |
Closed as fixed, but not actually fixed? :confused: |
|
Kind of sad really, seems that the goal of SDC was actually to ship markup, styles, and scripts in a single logical unit, but it appears that bikeshedding / vendor-lock-in may have won out in the end. (edited) |
| guptahemant |
i think all yaml based implementation are also a plugin, so same should be true for SDC. so it should be possible to register new components programatically, Will need deep dive into it to confirm further |
| Kristen Pol (she/her) |
that would be much slicker 🙂 |
| guptahemant |
These steps might help further on this https://drupal.slack.com/archives/C072JMEPUS1/p1721373285699089?thread_t... |
| Kristen Pol (she/her) |
This is on my list to retest to get into the dev guide doc |
| Kristen Pol (she/her) |
Is this what you ended up seeing @guptahemant? |
| guptahemant |
@Kristen Pol (she/her) Yes on /xb page i got the same output (edited) |
| guptahemant |
This is coming from components added in exp builder module. |
| Kristen Pol (she/her) |
Thanks for the confirmation... okay... I had the impression more was already committed... maybe I'll need to use one of the MRs (edited) |
| Kristen Pol (she/her) |
like https://git.drupalcode.org/project/experience_builder/-/merge_requests/2 |
| guptahemant |
Actually we just tried out few more things we can also get the edit working as well |
| guptahemant |
There are various hard codings as well in the code which we need to explore |
| Kristen Pol (she/her) |
Oh! How did you get the form to work? |
| Kristen Pol (she/her) |
I know about the node 1 loading thing |
| guptahemant |
web/modules/contrib/experience_builder/src/Form/ComponentPropsForm.phpIn this file need to change the node id $host_entity = Node::load(4);
if (!$host_entity || $host_entity->getType() !== 'article') {
throw new \LogicException('For now, this assumes node 1 exists and is an article!');
}In my case i changed it to 4 (edited) |
| Kristen Pol (she/her) |
I changed that to 3 in my case |
| Kristen Pol (she/her) |
Yeah |
| Kristen Pol (she/her) |
I found two spots when I looked earlier |
| Kristen Pol (she/her) |
Not sure why it wasn’t added as a query parameter at least for now (edited) |
| guptahemant |
My guess, Current code is highly experimental so to make it easier to progress things have been added like this. (edited) |
| Kristen Pol (she/her) |
Yeah but a query parameter is super easy to grab :) no worries |
| guptahemant |
Yes query param or something like /xb/{node} pattern would have been much easier (edited) |
Comments
Comment #2
smustgrave commentedComment #8
griffynh commentedComment #10
griffynh commentedComment #11
kristen pol@smustgrave There's a browser plugin that will grab all the text for you so you don't need to do screenshots. I haven't used it in awhile but it's used for other initiative meetings. I don't have it installed on my new computer and don't remember what it was called, but you can ping someone that uses it for another initiative.
Comment #12
smustgrave commentedThe browser plugin is currently broke
Comment #13
kristen pol😱 remind me what it’s called 🙏
Comment #14
smustgrave commentedSure https://github.com/mdlutz24/drupal-meeting-parser
Believe the open issue is what we are seeing.
Comment #15
smustgrave commentedComment #16
smustgrave commentedComment #21
kristen polAdding credit
Comment #22
kristen polLooks like a couple didn’t work… kimb0 and timbozeman. I’m on phone so hard to check these
Comment #23
smustgrave commentedkimb0 = kim.pepper
timbozeman = tim bozeman
Comment #26
kristen polAdding credit
Comment #27
wim leers