Problem/Motivation

There are many phpstan issue and phpcs issues reported by gitlab CI, hence as per drupal standard these issues should be fixed.
https://git.drupalcode.org/issue/config_update-3452453/-/pipelines/241400

CommentFileSizeAuthor
#7 Screenshot 2024-08-12 at 5.54.19 PM.png264.5 KBankitv18
#7 Screenshot 2024-08-12 at 5.51.49 PM.png435.13 KBankitv18
#7 Screenshot 2024-08-12 at 5.47.53 PM.png95.53 KBankitv18

Issue fork config_update-3465396

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

deepakkm created an issue. See original summary.

deepakkm opened merge request !14

ankitv18 made their first commit to this issue’s fork.

ankitv18’s picture

ankitv18 commented
Status: Needs work » Needs review

Please review MR!14

deepak5423’s picture

deepak5423 commented
Status: Needs review » Reviewed & tested by the community

Hi,

I have tested the MR !14.
All the issues of phpstan and phpcs are fixed.
Moving the issue to RTBC.

Thanks.

ankitv18’s picture

ankitv18 commented
Title: Fix phpstan and phpcs issues reported in gitlab CI » Fix validate pipeline
ankitv18’s picture

ankitv18 commented
StatusFileSize
new Screenshot 2024-08-12 at 5.47.53 PM.png95.53 KB
new Screenshot 2024-08-12 at 5.51.49 PM.png435.13 KB
new Screenshot 2024-08-12 at 5.54.19 PM.png264.5 KB

Validated on local with these changes ~~ functionalities are working fine
Enable module

Report page
Report page

vishalkhode’s picture

vishalkhode commented
Status: Reviewed & tested by the community » Needs work

Requested some changes, hence moving it back to Needs Work. Also, let's not skip eslint and fix that as well. If that's a major change and required more changes, we can skip eslint and cslint for now and handle that in a separate ticket and limit this ticket for PHPCS and PHPStan fixes only.

ankitv18’s picture

ankitv18 commented
Status: Needs work » Needs review

Addressed the MR feedback, hence moving into review.

vishalkhode’s picture

vishalkhode commented

I ran the ESlint in local and it showed errors in config_update_ui.settings.yml file. I think we should handle & fix that in a separate ticket. So, I'm Ok, if we've skipped the ESlint job here, as we can enable back again and fix it separately. Thanks.

ankitv18’s picture

ankitv18 commented
Related issues: +#3467752: Fix ESLINT job

vishalkhode credited chaitanyadessai.

vishalkhode’s picture

vishalkhode commented
Status: Needs review » Fixed
Related issues: +#3467805: Replace dynamic extension.list.$type service with extension.path.resolver service object

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.