Problem/Motivation
Right now, since SDDS is based on CivicTheme which requires a number of contributed modules, those modules need to be installed to install SDDS. We want to minimize the dependency requirements to make it easier to install SDDS for the demo and for people testing.
Steps to reproduce
Proposed resolution
Figure out which modules can be removed from the dependencies.
Remaining tasks
- Go through all modules separately and analyze which can be removed
- Consider how these could be added optionally
- Test without those modules
- Update docs to reflect these changes
Current dependencies that are currently in Starshot
- drupal:block_content
- drupal:config
- drupal:content_moderation
- drupal:focal_point
- drupal:help
- drupal:image
- drupal:inline_form_errors
- drupal:media
- drupal:media_library
- drupal:node
- drupal:options
- drupal:shortcut
- drupal:system
- drupal:taxonomy
- drupal:user
- drupal:views
- linkit:linkit
- pathauto:pathauto
- redirect:redirect
- webform:webform
Current dependencies that are currently in Starshot but will be replaced by XB
- drupal:layout_builder (replaced by XB)
- drupal:layout_discovery (replaced by XB)
Current dependencies that need analysis
- components:components (replaced by SDC)
- drupal:datetime_range
- drupal:ckeditor (replaced by ckeditor5, current config is actually for ckeditor5)
- drupal:rest
- field_group:field_group
- layout_builder_restrictions:layout_builder_restrictions (replaced by XB)
- menu_block:menu_block
- paragraphs:paragraphs (replaced by XB)
- search_api:search_api (optional config)
- search_api:search_api_db (optional config)
User interface changes
Some of the CivicTheme functionality like search or page building via paragraphs won't be available in the demo. If possible, we can make these an optional feature that could be turned on separately.
API changes
Data model changes
Issue fork demo_design_system-3465047
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3465047-meta-remove-unnecessary
changes, plain diff MR !25
Comments
Comment #2
kristen polAdd the dependencies to the summary.
Comment #3
kristen polAdd more clarification.
Comment #4
kristen polCurrently Starshot adds these out-of-the-box:
Comment #5
kristen polUpdate summary to pull out ones that are already in the Starshot install.
Comment #6
kristen polUpdate to include dependencies that aren't listed in the composer.json file.
Comment #7
kristen polAssigning to Richard to review and we can discuss.
Comment #8
kristen polI need to look at this because XB doesn't work with Drupal CMS (Starshot) right now so I want to see if I can remove some dependencies to help with the installation process.
Comment #9
kristen polI'm going to check which of these have Drupal 11 versions for now since maybe we can worry about the dependency removal in a week or two after things have settled down more.
Comment #10
kristen polD11 analysis:
Core (enabled with standard profile)
Core (not enabled with standard profile)
Contributed projects with D11 release
Contributed projects without D11 release or branch
Comment #11
kristen polconfig analysis
theme settings
civictheme.settings.yml
other config
Perhaps some/all of this can be moved to "optional":
Comment #12
kristen polBumping priority now that the XB team wants us to focus on using D11 standard profile rather than Starshot / Drupal CMS.
Comment #13
kristen polI am updating this project to be D11 compatible, but that's in name only because components and webform don't have a D11 dev branch to use or a MR/patch that's ready.
This is now a blocker so I'm not looking at moving all the config except for
civictheme.settings.ymlto optional config and see how it goes.Comment #14
kristen polI was successful in moving all the config except the theme settings to optional config and removing the dependencies from the info file. This has been committed. Now I need to update the dev guide to reflect this.
Comment #15
kristen polOnce #3469511: Update SDDS development guide to use standard Drupal 10 profile and XB been reviewed by others and is okay then this one can be marked fixed.
Comment #18
sea2709 commented@Kristen: I removed unnecessary dependencies from composer.json of starshot_demo_design theme , I updated the package name as well (hopefully it's appropriate).
I tested this change by using composer to add starshot_demo_theme package, and I didn't see composer errors with missing dependencies!
MR is ready for review https://git.drupalcode.org/project/demo_design_system/-/merge_requests/25
Comment #19
kristen polMarking postponed until we determine outcome of this one:
#3469985: Reconcile components module vs SDC namespaces for SDDS includes/embeds
Comment #21
kristen polEverything was removed from a dependency so far except components module which I'll make a follow-up issue for that.
Comment #22
kristen polActually, we already have:
#3469985: Reconcile components module vs SDC namespaces for SDDS includes/embeds
so that's fine for the follow-up issue.