The tests can be improved. For example:

  1. Tests should verify the APCu extension has been loaded and its functions are available
  2. Tests should verify the cache bins used for the tests are effectively handled by the DrupalApcCache class
  3. Tests should use DrupalTestCase::randomName() and DrupalTestCase::randomString() for the test data, when possible
  4. Tests should verify that other data written in the APCu storage from other modules are not changed from this module
  5. Tests should verify that data written in the APCu storage with a 0 TTL are still stored after X seconds
  6. Tests should not call an assertXYZ() method when a previous related call to another assertZYX() method failed

Issue fork apc-3464533

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

avpaderno created an issue. See original summary.

avpaderno’s picture

The lines to add to the .gitlab-ci.yml file should be the following ones.

.phpunit-base:
  before_script:
    - apt-get update
    - apt-get install -y --no-install-recommends $PHPIZE_DEPS
    - pecl install apcu && docker-php-ext-enable apcu

avpaderno’s picture

Status: Active » Needs review
avpaderno’s picture

Title: Re-enable the PHPUnit tests on GitLab » Improve the tests
Issue summary: View changes

So far, I have not been able to make all the tests pass. The tests have been improved, but they cannot yet be enabled for GitLab CI.

avpaderno’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.