Problem/Motivation

In my country (France, Switzerland) the default setting in windows to export a csv file is with semicolon delimiters.
I have several users, some are able to configure excel to export with a comma separator and some are not.
I need the possibility for the user to chose the CSV delimiter each time they import csv data to create a new chart.

Proposed resolution

Add a "CSV separator" text field in chart element form and pass the user input value when processing the CSV file.

Remaining tasks

Create a patch

User interface changes

  • New "CSV separator" field in chart default value configuration form
  • New "CSV separator" field in chart field form
CommentFileSizeAuthor
#2 csv-separator-field-3463501-2.patch1.05 KBolivier.br

Issue fork charts-3463501

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

olivier.br created an issue. See original summary.

olivier.br’s picture

olivier.br commented
StatusFileSize
new csv-separator-field-3463501-2.patch1.05 KB

Here is a first attempt.

andileco’s picture

andileco commented
Status: Active » Needs review

andileco changed the visibility of the branch 3463501-add-the-possibility to hidden.

andileco opened merge request !108

andileco credited nikathone.

andileco’s picture

andileco commented

Thank you, @olivier.br - great idea! @nikathone and I have made a different patch that we prefer because it only touches the ChartDataCollectorTable.php file rather than the base settings. This allows users to select the separator at the point of upload, as there may be cases where the separator that's generally used is not used for a specific file.

  • andileco committed 9bbbfecf on 5.1.x 
    Issue #3463501 by andileco, olivier.br, nikathone: Add the possibility...
andileco’s picture

andileco commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

andileco’s picture

andileco commented
Version: 5.1.x-dev » 5.0.x-dev
Status: Closed (fixed) » Needs review

  • andileco committed 0c53f7ba on 5.0.x 
    Issue #3463501 by andileco, olivier.br, nikathone: Add the possibility...
andileco’s picture

andileco commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.