Problem/Motivation

#3463301: Setup GitLab CI reports eslint issues in the GitLab CI pipeline, see https://git.drupalcode.org/project/ajax_comments/-/pipelines

Proposed resolution

Fix eslint issues reported in GitLab CI pipeline

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork ajax_comments-3463306

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

idebr created an issue. See original summary.

tirupati_singh’s picture

tirupati_singh commented
Assigned: Unassigned » tirupati_singh

I'm working on it.

Tirupati_Singh opened merge request !19

tirupati_singh’s picture

tirupati_singh commented
Assigned: tirupati_singh » Unassigned
Status: Active » Needs review

Hi @idebr, I've fixed the eslint issues. Please review the MR.

idebr’s picture

idebr commented
Status: Needs review » Needs work

jQuery .animate can be replaced with the vanilla window.scrollTo(), see for reference #3239139: Refactor (if feasible) uses of the jQuery animate function to use Vanilla/native

tirupati_singh’s picture

tirupati_singh commented
Assigned: Unassigned » tirupati_singh
tirupati_singh’s picture

tirupati_singh commented
Assigned: tirupati_singh » Unassigned
Status: Needs work » Needs review

Hi @idebr, I'v replaced the animate() with window.scrollTo(). Please review the MR changes.

idebr’s picture

idebr commented
Status: Needs review » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.