Problem/Motivation

Once #3421202: Enable W3C-compliant webdriver testing lands we will be able to test using selenium/standalone-firefox.

Steps to reproduce

Add

.with-selenium-firefox: &with-selenium-firefox
  name: selenium/standalone-firefox:127.0
  alias: selenium
  variables:
    JAVA_OPTS: "-Dwebdriver.firefox.logfile=/builds/geckodriver.log"
    SE_NODE_OVERRIDE_MAX_SESSIONS: "true"
    SE_NODE_MAX_SESSIONS: "5"
    SE_START_XVFB: "false"
    SE_START_VNC: "false"

'🖱️️️ PHPUnit Functional Javascript (selenium firefox)':
  <<: [ *with-composer, *run-tests, *default-job-settings ]
  when: manual
  parallel: 4
  variables:
    TESTSUITE: PHPUnit-FunctionalJavascript
    CONCURRENCY: 15
    KUBERNETES_CPU_REQUEST: "24"
    MINK_DRIVER_ARGS_WEBDRIVER: $MINK_DRIVER_ARGS_WEBDRIVER_FIREFOX_W3C
  services:
    - <<: *with-database
    - <<: *with-selenium-firefox
  after_script:
    - echo $MINK_DRIVER_ARGS_WEBDRIVER
    - sed -i "s#$CI_PROJECT_DIR/##" ./sites/default/files/simpletest/phpunit-*.xml || true
    - cp /builds/geckodriver.log ./

To gitlab pipeline.

Proposed resolution

Remaining tasks

Reviews

User interface changes

None

API changes

TBD - hopefully none

Data model changes

None

Release notes snippet

TBD

Issue fork drupal-3462680

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

alexpott created an issue. See original summary.

alexpott’s picture

Issue summary: View changes
alexpott’s picture

Status: Postponed » Needs work
alexpott’s picture

Issue summary: View changes
Status: Needs work » Needs review

Updated issue summary

smustgrave’s picture

Status: Needs review » Needs work

Seems some work still going on in #3421202: Enable W3C-compliant webdriver testing

alexpott’s picture

Status: Needs work » Needs review

@smustgrave that's backports

smustgrave’s picture

MR appears to need rebase and has test failures too

alexpott’s picture

@smustgrave yeah I'm waiting on upstream changes - this is all in the issue summary. The changes necessary to make tests on firefox can stll be reviewed. Hence the issue status.

alexpott’s picture

Issue summary: View changes

We're green on firefox and chrome with no hacks to the codebase. Upstream fixes have been merged - thanks @justafish and @longwave.

This is now very ready for review.

andypost’s picture

Quickly skimmed and it's mostly test changes, and new Todo needs issue

alexpott’s picture

I think the @todo's should be decided here - they are really about the issue - i.e should be testing things that seem untestable on firefox - or am I wrong and what we have here is a detectable firefox bug... for example is text just not appearing in firefox even though it is in chrome.

smustgrave’s picture

Would the todo's be good follow ups tagged novice?

smustgrave’s picture

just following up if the todos should be follow ups?

needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new90 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

alexpott’s picture

Status: Needs work » Needs review
smustgrave’s picture

Seems to have test failures and may be waiting on other tickets right?

What’s a good way to review this one?

needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new90 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

godotislate’s picture

Added this as a related issue to #3495881: Firefox retains form_build_id on form reloads, causing old form cache entry to be used and creating weird behavior for the Media Library widget. Once Firefox testing is in, there should be a test for the form reload behavior documented there.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.