Needs work
Project:
Drupal core
Version:
main
Component:
phpunit
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 Jul 2024 at 13:53 UTC
Updated:
3 Feb 2025 at 17:41 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
alexpottComment #4
alexpott#3421202: Enable W3C-compliant webdriver testing has landed
Comment #5
alexpottUpdated issue summary
Comment #6
smustgrave commentedSeems some work still going on in #3421202: Enable W3C-compliant webdriver testing
Comment #7
alexpott@smustgrave that's backports
Comment #8
smustgrave commentedMR appears to need rebase and has test failures too
Comment #9
alexpott@smustgrave yeah I'm waiting on upstream changes - this is all in the issue summary. The changes necessary to make tests on firefox can stll be reviewed. Hence the issue status.
Comment #10
alexpottWe're green on firefox and chrome with no hacks to the codebase. Upstream fixes have been merged - thanks @justafish and @longwave.
This is now very ready for review.
Comment #11
andypostQuickly skimmed and it's mostly test changes, and new Todo needs issue
Comment #12
alexpottI think the @todo's should be decided here - they are really about the issue - i.e should be testing things that seem untestable on firefox - or am I wrong and what we have here is a detectable firefox bug... for example is text just not appearing in firefox even though it is in chrome.
Comment #13
smustgrave commentedWould the todo's be good follow ups tagged novice?
Comment #14
smustgrave commentedjust following up if the todos should be follow ups?
Comment #15
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #16
alexpottComment #17
smustgrave commentedSeems to have test failures and may be waiting on other tickets right?
What’s a good way to review this one?
Comment #18
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #19
godotislateAdded this as a related issue to #3495881: Firefox retains form_build_id on form reloads, causing old form cache entry to be used and creating weird behavior for the Media Library widget. Once Firefox testing is in, there should be a test for the form reload behavior documented there.