Overview
At present we're hard coding loading node 1 — see \Drupal\experience_builder\Controller\SdcController::layout().
Clearly this is not going to be the final solution
Proposed resolution
Add entity type, id (and view mode?) to configuration slice.
Boot the app with these from drupalSettings in Drupal context.
Use those in rawBaseQuery to do slug replacements.
Update the URLs in FE to include the slugs.
Update Drupal route to do the param upcasting.
User interface changes
| Comment | File | Size | Author |
|---|---|---|---|
| #17 | Screenshot 2024-08-02 at 6.51.29 PM.png | 32.27 KB | wim leers |
Issue fork experience_builder-3462247
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
wim leersYes, please!
\Drupal\experience_builder\Controller\SdcController::layout()has this horribleness:That's something that this should remove 🤓
(Thanks for creating this issue!)
I'm running into this too over at #3461422: Evolve component instance edit form to become simpler: generate a Field Widget directly.
Comment #3
wim leersEnsuring this shows up on https://contribkanban.com/board/experience_builder.
Comment #5
larowlanComment #6
wim leersAre these commit messages auto-generated and random? 🤪🤣
Comment #7
wim leersThe MR indicates that this depends on #3465107: Clarify if local dev on /ui should be possible without Drupal, reflecting that.
Comment #8
wim leers#3465107: Clarify if local dev on /ui should be possible without Drupal should land first, but that didn't stop me from reviewing 😊
Comment #9
larowlanNa, I'm just having fun with portlandia quotes
Comment #10
wim leersThe back-end changes here (in the controllers +
*.routing.yml) make sense.The front-end changes I'd like to be reviewed by either @bnjmnm or @jessebaker 😊
Comment #12
bnjmnmFE looks good
Comment #13
larowlanComment #14
wim leersComment #16
wim leersComment #17
wim leersThis caused a small regression, which #3462709: Introduce `hook_storable_prop_shape_alter()`, use it to prefer the Media Library widget for "image" PropShape if Media Library is installed surfaced. Fixed by removing one character in https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
Comment #18
wim leersThis introduced a regression: #3466531: Regression caused by #3462247: `configure` route in *.info.yml missing mandatory parameters.