Problem/Motivation
When using the withdraw button a click handler is bound to .eu-cookie-withdraw-tab everytime the button is pressed. When the animation time is set to 0 the banner cannot be opened, because the toggleWithdrawBanner function is called twice and closes the banner immediately.
Steps to reproduce
- Use following settings:
method: 'opt_in' withdraw_enabled: true settings_tab_enabled: true popup_delay: 0 - Click "No, thanks"
- Click "Privacy settings"
- Look at events on .eu-cookie-withdraw-tab:
jQuery._data( jQuery(".eu-cookie-withdraw-tab")[0], "events" ); Object { click: (2) […] }
Proposed resolution
Do not bind the click handler in declineAction.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 3462240-5.patch | 67.69 KB | lmoeni |
| #4 | 3462240-4.patch | 67.44 KB | hosterholz |
| #3 | 3462240-3.patch | 66.16 KB | hosterholz |
Issue fork eu_cookie_compliance-3462240
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
hosterholzPatch for 1.24
Comment #4
hosterholzPatch for 1.25
Comment #6
lmoeniI rebased the merge request and created a new patch for 1.26.
Comment #7
lmoeniComment #8
atowl commentedHi @lmoeni
Is MR141 good to go here?
Comment #9
lmoeniHi @atowl
Yes it should be good to go.
Comment #10
atowl commentedThanks everyone for your help on this issue,
I've merged this in, will be available in the next release shortly
Comment #12
atowl commented