Problem/Motivation

Fix phpcs and cspell issues reported in gitlab
Lastest phpcs pipeline: https://git.drupalcode.org/project/metatag/-/jobs/2135246

Proposed resolution

Enable cspell pipeline to fix cspell pipeline.
Fix both cspell and phpcs pipeline.
Try to attempt to fix eslint pipeline too.

Issue fork metatag-3462134

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ankitv18 created an issue. See original summary.

ankitv18 opened merge request !125

ankitv18’s picture

ankitv18 commented
Assigned: ankitv18 » Unassigned
Status: Active » Needs review

Please review MR!125, pipelines for cspell and phpcs are fixed now.

ankitv18’s picture

ankitv18 commented
Issue summary: View changes
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

Thank you!

Can you please update the gitlab-ci config to not ignore failing phpcs and cspell tests? Thank you.

ankitv18’s picture

ankitv18 commented
Status: Needs work » Needs review

@DamienMcKenna Configured failure of pipelines for phpcs and cspell in the gitlab.

deepakkm’s picture

deepakkm commented
Status: Needs review » Reviewed & tested by the community
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #3423883: Plan for Metatag 2.0.1

What are the errors like if MetatagApiTest.php doesn't have phpcs:ignoreFile?

ankitv18’s picture

ankitv18 commented

@DamienMcKenna Removed phpcs:ignoreFile and fix with the relevant changes.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

Thank you! This looks great.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #3423883: Plan for Metatag 2.0.1 » #3370435: Plan for Metatag 2.0.1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.