Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork cas-3461478

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea opened merge request !38

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Version: 2.x-dev » 3.x-dev

Fix branch

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Assigned: Unassigned » claudiu.cristea

Working on this

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Assigned: claudiu.cristea » Unassigned
Status: Active » Needs review

This is ready for review.

Contains:

  • Drupal 11 compatibility
  • Testing extended to cover:
    • Drupal stable version (currently 10.3.x) which runs for lowest supported PHP (currently PHP 8.1) and highest supported PHP (currently PHP 8.3)
    • Drupal next major release (currently 11) which runs with highest supported PHP (currently PHP 8.3)
  • Converted ServiceControllerTest unit test to kernel test
  • Converted CasProxyHelperTest::testProxyAuthenticate() unit test to kernel test
  • Removed the backwards compatibility deprecated layer
  • Started modernization of code (this process should continue in the alpha stage):
    • Removed constructor documentation because is useless and only adds noise to the code. There are some exceptions where documenting the parameters is important.
    • Switched to constructor property promotion. Some exceptions were kept because of compatibility with Drupal 10.3.x.
    • Added strict_type=1 declaration to all PHP files
bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Status: Needs review » Needs work
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Needs work » Needs review

Ready for a 2nd round of review. Fixed some and answered the other

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Reviewed & tested by the community » Fixed

Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.