Closed (fixed)
Project:
Advanced PWA inc Push Notifications
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
11 Jul 2024 at 12:05 UTC
Updated:
1 Aug 2024 at 08:14 UTC
Jump to comment: Most recent
Comments
Comment #4
sarwan_verma commentedHi @2dareis2do,
I have created MR!11 for the above issue, Please review it once.
Comment #5
2dareis2do commentedPatch (diff) applies and fixes Warning
Many thanks
Comment #6
2dareis2do commentedComment #8
gmaximus commentedComment #9
sarwan_verma commentedhey @gMaximus,
when you move an issue to the "Fixed" state, please remember to give credit to the contributors.
Thankyou !
Comment #10
gmaximus commentedHi @sarwan_verma,
Crediting is something very important to me.
In the commit above, it shows committed by me and authored by you?
Am I missing something? I want it to be right
Comment #11
gmaximus commentedMy bad. I missed a step. I originally believed that by using the correct commit message, everything else happened.
Thanks for pointing this out. I'll do the same for other fixed issues.