Overview

The components have several different states that need to be implemented. We should consider at least the following states:

  1. Hover
  2. Active/Focus
  3. Drag

User interface changes

Design


Figma prototype

Implementation

From #9:

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

lauriii created an issue. See original summary.

lauriii’s picture

lauriii’s picture

Assigned: hooroomoo » jessebaker

jessebaker made their first commit to this issue’s fork.

larowlan’s picture

@lauriii is that screenshot correct - its the same one as #3460955

larowlan’s picture

Ah I see, same screenshot, different feature, ignore me

wim leers’s picture

Assigned: jessebaker » bnjmnm
Status: Active » Needs review
Issue tags: +Needs screenshots
jessebaker’s picture

StatusFileSize
new891.53 KB

Implementation:

bnjmnm’s picture

Assigned: bnjmnm » Unassigned
Status: Needs review » Needs work

Although we're waiting to take care of a few e2e things in gitlab, component/unit tests are working fine and these should get at least surface level testing

wim leers’s picture

Assigned: Unassigned » jessebaker
Issue summary: View changes
Issue tags: -Needs screenshots +Needs tests

#9: updated issue summary 👍 Also … 🤩

Needs tests per #10.

jessebaker’s picture

I've taken a stab at making a Cypress component test - I'm not sure how to get around how much fake/boilerplate code I had to wrap it all in to make it work though.

Perhaps a candidate to replace with a proper e2e test at some point.

jessebaker’s picture

Assigned: jessebaker » bnjmnm
Status: Needs work » Needs review
jessebaker’s picture

Current status:

Due to the overlap in functionality (regarding positioning the UI elements over components in the preview), the code in the MR for this issue (!93) was used as the base for !99 which is addressing #3460952.

That means that once !99 is approved and merged, this work will also be merged in as part of that.

Or, if this MR gets approved, it can be merged first independently.

wim leers’s picture

So based on #14, it sounds like it doesn't matter which lands first:

That first bullet is preferable, because it makes the individual MRs/commits to 0.x simpler.

Is that right?

jessebaker’s picture

@Wim Leers you are correct.

bnjmnm’s picture

Status: Needs review » Needs work

The automated tests prompted me to run a manual A11y check on on the page

There is an AA contrast violation on
div:nth-child(1) > ._previewContainer_14ww3_31 > ._xbComponentToolbar_lmyju_17.rt-Box[data-state="closed"] > ._nameTag_1uhn3_1._selected_1uhn3_11

on

<div class="_nameTag_1uhn3_1 _selected_1uhn3_11">

(obviously these are hashed classnames but it is safe to assume they are part of the NameTag component introduced in this issue.


Lets also dump the Outline‎.cy.jsx‎ test entirely and just add a few lines to existing e2e tests.

hooroomoo made their first commit to this issue’s fork.

hooroomoo’s picture

Status: Needs work » Needs review
Issue tags: -Needs tests
bnjmnm’s picture

Assigned: bnjmnm » Unassigned

  • bnjmnm committed 8c034376 on 0.x authored by jessebaker
    Issue #3460783 by jessebaker, bnjmnm, larowlan: Implement component...
bnjmnm’s picture

Status: Needs review » Fixed

Looks good - this is in!

bnjmnm’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.