Overview

Add some SDC's so that people can see something that looks nice after checking out the module.

Issue fork experience_builder-3459992

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jessebaker created an issue. See original summary.

jessebaker opened merge request !81

jessebaker’s picture

jessebaker commented
Assigned: jessebaker » wim leers

@wim leers I've made an MR to add a pair of SDC's to the main XB repo but it appears that in doing so it has broken the tests and I'm unsure how to resolve them. The test (web/modules/experience_builder/tests/src/Kernel/SdcPropToFieldTypePropTest.php) appears to be coded to expect a certain set of SDCs but I don't know how to re-generate the data being compared in the test to include the new SDCs that I've added.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Parent issue: » #3450592: [META] Front-end Kanban issue tracker
Related issues: +#3452512: Add component instance edit form to contextual panel

Thanks — I'll get those fixed!

This will also help make #3452512: Add component instance edit form to contextual panel's MR (https://git.drupalcode.org/project/experience_builder/-/merge_requests/53) smaller 👍

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
Status: Active » Reviewed & tested by the community

Done.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +blocker

This was a soft blocker to #3452512: Add component instance edit form to contextual panel — allowing that MR to become smaller again. 👍

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.