Overview
I don't think this is needed after #3452497: [MR Only] Edit any component prop, powered by a new FieldForComponentSuggester service, which will power the JS UI landed and removing the dependency will remove the need to deal with $settings['extension_discovery_scan_tests']
Proposed resolution
Remove this dependency and hence modify the default XB field value.
User interface changes
Different default XB field value.
Issue fork experience_builder-3461101
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
lauriiiComment #3
wim leersAh, fair point — that was something I did not notice at all, because I always have that enabled. My bad — sorry for the lack of empathy on my side there 🙈
This is actually only feasible since #3459992: Add some basic example SDCs, because since that issue landed 5 days ago, we now have a few SDCs in the XB module itself — that's why I made XB depend on the
sdc_testmodule: to have some SDCs at all.Comment #5
wim leersComment #6
wim leersGreen — ready for review by @bnjmnm, since he spotted this DX problem! 👍
Comment #7
bnjmnmLeft a comment on the MR about a change I had to make that isn't in-in-in scope but might work well here assuming it isn't something in the PHP that caused the issue. LMK
Comment #8
wim leersBased on 2+3, I think @bnjmnm did intend to approve this MR.
Given the huge impact of #3461435: End-to-end test that tests both the client (UI) and server for team/project velocity … I'm going ahead and am merging this MR.
Comment #9
wim leersComment #11
wim leers