Overview

I don't think this is needed after #3452497: [MR Only] Edit any component prop, powered by a new FieldForComponentSuggester service, which will power the JS UI landed and removing the dependency will remove the need to deal with $settings['extension_discovery_scan_tests']

Proposed resolution

Remove this dependency and hence modify the default XB field value.

User interface changes

Different default XB field value.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

bnjmnm created an issue. See original summary.

lauriii’s picture

wim leers’s picture

Assigned: Unassigned » wim leers
Issue summary: View changes
Issue tags: +DX (Developer Experience)

will remove the need to deal with $settings['extension_discovery_scan_tests']

Ah, fair point — that was something I did not notice at all, because I always have that enabled. My bad — sorry for the lack of empathy on my side there 🙈

This is actually only feasible since #3459992: Add some basic example SDCs, because since that issue landed 5 days ago, we now have a few SDCs in the XB module itself — that's why I made XB depend on the sdc_test module: to have some SDCs at all.

wim leers’s picture

wim leers’s picture

Green — ready for review by @bnjmnm, since he spotted this DX problem! 👍

bnjmnm’s picture

Assigned: bnjmnm » Unassigned

Left a comment on the MR about a change I had to make that isn't in-in-in scope but might work well here assuming it isn't something in the PHP that caused the issue. LMK

wim leers’s picture

Status: Needs review » Reviewed & tested by the community
  1. @bnjmnm didn't approve this MR 😅
  2. @bnjmnm's #7 and his sole change suggest he's +1 to this MR
  3. @bnjmnm did write over at #3461435-5: End-to-end test that tests both the client (UI) and server that he's built that on top of this MR, because it simplifies things.

Based on 2+3, I think @bnjmnm did intend to approve this MR.

Given the huge impact of #3461435: End-to-end test that tests both the client (UI) and server for team/project velocity … I'm going ahead and am merging this MR.

wim leers’s picture

Status: Reviewed & tested by the community » Fixed

  • Wim Leers committed 272c596a on 0.x
    Issue #3461101 by Wim Leers, bnjmnm: Remove dependency on sdc_test
    
wim leers’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.