Adopt vincentlanglet/twig-cs-fixer for Twig coding standards [#3458957]

Problem/Motivation

Drupal Core is planning to #3284817: Adopt vincentlanglet/twig-cs-fixer for Twig coding standards

Let's do the same in our codebase.

Proposed resolution

In this issue PR, run vendor/bin/twig-cs-fixer lint --fix /path/to/code a first time.

Do we also need to add something somewhere (README, Makefile...)?

Issue fork ui_suite_bootstrap-3458957

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3458957-adopt-vincentlanglettwig-cs-fixer-for changes, plain diff MR !331
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

4 July 2024 at 07:53

pdureau created an issue. See original summary.

Comment #2

silvi.addweb commented 5 July 2024 at 10:41

Assigned:

Unassigned

» silvi.addweb

Comment #3

pdureau commented 5 July 2024 at 10:59

Hi Silvi,

Welcome to the UI Suite Bootstrap project

Don't take the issue only to run the command. This is something anybody can do and your MR may not be accepted. You are welcomed to join us to discuss about improving our stack (CI, documentation...)

Comment #4

grimreaper

French

France 🇫🇷

commented 12 July 2024 at 11:39

Assigned:	silvi.addweb	» Unassigned
Status:	Active	» Postponed
Related issues:		+#3284817: Adopt vincentlanglet/twig-cs-fixer for Twig coding standards, +#3437838: Investigate how TWIG linter CI job could be added

Hi,

Postponing until core issue is resolved and the tool is integrated into Drupal Gitlab CI template (we can do an issue to push it forward once core will adopt it)