Problem/Motivation

Drupal Core is planning to #3284817: Adopt vincentlanglet/twig-cs-fixer for Twig coding standards

Let's do the same in our codebase.

Proposed resolution

In this issue PR, run vendor/bin/twig-cs-fixer lint --fix /path/to/code a first time.

Do we also need to add something somewhere (README, Makefile...)?

Comments

pdureau created an issue. See original summary.

silvi.addweb’s picture

silvi.addweb commented
Assigned: Unassigned » silvi.addweb
pdureau’s picture

pdureau commented

Hi Silvi,

Welcome to the UI Suite Bootstrap project

Don't take the issue only to run the command. This is something anybody can do and your MR may not be accepted. You are welcomed to join us to discuss about improving our stack (CI, documentation...)

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: silvi.addweb » Unassigned
Status: Active » Postponed
Related issues: +#3284817: Adopt vincentlanglet/twig-cs-fixer for Twig coding standards, +#3437838: Investigate how TWIG linter CI job could be added

Hi,

Postponing until core issue is resolved and the tool is integrated into Drupal Gitlab CI template (we can do an issue to push it forward once core will adopt it)

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Version: 5.0.x-dev » 5.1.x-dev
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Version: 5.1.x-dev » 5.2.x-dev