Problem/Motivation

I can see issue with Drupal 11 when visiting configuration page: /admin/config/acquia-dam

Steps to reproduce

  1. Setup drupal11 site
  2. Enable this module
  3. Login to your site with admin creds
  4. Visit dam configuration page: example.com/admin/config/acquia-dam, you will see WSOD

Proposed resolution

As per the change introduced in core, it is mandatory to provide \Drupal\Core\Config\TypedConfigManagerInterface in ConfigFormBase::__construct

CommentFileSizeAuthor
#15 Screenshot 2024-07-30 at 15-14-07 Appearance Drush Site-Install.png555.15 KBchandu7929
#13 Screenshot 2024-07-30 at 14-42-09 Create Basic page Drush Site-Install.png196.34 KBchandu7929
#12 3458567-12_frontend-misalignment-2.png37.61 KBbaluertl
#12 3458567-12_frontend-misalignment-1.png48.54 KBbaluertl

Issue fork acquia_dam-3458567

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chandu7929 created an issue. See original summary.

ankitv18 made their first commit to this issue’s fork.

ankitv18 opened merge request !59

ankitv18’s picture

ankitv18 commented
Status: Active » Needs review

MR!59 is ready for a review.

chandu7929’s picture

chandu7929 commented

Changes looks good to me, also verified locally now I am able to access /admin/config/acquia-dam page without any error. Hence RTBC.

chandu7929’s picture

chandu7929 commented
Status: Needs review » Reviewed & tested by the community

deepakkm made their first commit to this issue’s fork.

deepakkm’s picture

deepakkm commented

RTBC + 1

chandu7929’s picture

chandu7929 commented
Status: Reviewed & tested by the community » Needs work

Need to add NEXT_MAJOR.

hetal.solanki’s picture

hetal.solanki
Primary language English
commented
Status: Needs work » Needs review
chandu7929’s picture

chandu7929 commented
Status: Needs review » Needs work

@Hetal.Solanki we can't move issue in needs review unless CI is green, why do you think its ready for review?

baluertl’s picture

baluertl
he/him
Primary language Hungarian
Location Budapest 🇪🇺
commented
StatusFileSize
new 3458567-12_frontend-misalignment-1.png48.54 KB
new 3458567-12_frontend-misalignment-2.png37.61 KB

Now tested this MR on a D11-rc1 site and although the backend functionality works as expected, but some frontend misalignment occurs on my side with Core's default theme:

Screenshot
Screenshot

Can anyone else confirm as well?

chandu7929’s picture

chandu7929 commented
StatusFileSize
new Screenshot 2024-07-30 at 14-42-09 Create Basic page Drush Site-Install.png196.34 KB

@balu-ertl I don't see such behaviour on a D11-rc1 D11-rc1

baluertl’s picture

baluertl
he/him
Primary language Hungarian
Location Budapest 🇪🇺
commented

@chandu7929 we're using different themes. The modal has a black header on my screenshots, yours has a dark blue. What happens if you switch your admin theme to core's Claro, please?

chandu7929’s picture

chandu7929 commented
StatusFileSize
new Screenshot 2024-07-30 at 15-14-07 Appearance Drush Site-Install.png555.15 KB

I am testing this on Vanilla drupal D11-rc1 without any customisation, and yes Claro is set as default admin theme.
core theme

chandu7929’s picture

chandu7929 commented

All tests for D10 & D11 has been fixed. Need to check failing test for D9.5

japerry made their first commit to this issue’s fork.

japerry opened merge request !65

  • japerry committed e7cf7a05 on 1.0.x 
    Issue #3458567: Drupal 11 fixes for acquia_dam

japerry opened merge request !66

  • japerry committed 6789670b on 1.1.x 
    Issue #3458567: Drupal 11 fixes for acquia_dam
japerry’s picture

japerry
Location KOMK
commented
Status: Needs work » Fixed

Balu Ertl changed the visibility of the branch 3458567-drupal11-fixes to hidden.

Balu Ertl changed the visibility of the branch 3458567-drupal-11-fixes to hidden.

Balu Ertl changed the visibility of the branch 3458567-drupal11-fixes to active.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

baluertl closed merge request !59