Problem/Motivation

After upgrading to Drupal core 10.3, which updates CKEditor to version 4.13.1, I now see this error being thrown: TypeError: t.Model is not a constructor in the console when loading up a CKEditor instance.

Official CKEditor documentation that shows the API was changed:
https://ckeditor.com/docs/ckeditor5/latest/updating/guides/update-to-41....

Proposed resolution

Update the CKEditor5 plugin dependencies and correct any incompatible code.

CommentFileSizeAuthor
#9 ckeditor_media_resize-n3458385-9.patch896.22 KBdamienmckenna
#7 ckeditor_media_resize-n3458385-7.patch262.2 KBdamienmckenna
#7 ckeditor_media_resize-n3458385-7.interdiff.txt765 bytesdamienmckenna
#6 ckeditor_media_resize--2024-07-23-6.patch277.57 KBammar_ar
#5 ckeditor5_media_resize_update_ck5_plugin-15671444-4.patch261.5 KBvlyalko

Issue fork ckeditor_media_resize-3458385

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

droath created an issue. See original summary.

droath opened merge request !10

droath’s picture

droath commented
Status: Active » Needs review
vlyalko’s picture

vlyalko commented

Upgraded to 10.3 and experiencing the same issue.

vlyalko’s picture

vlyalko commented
StatusFileSize
new ckeditor5_media_resize_update_ck5_plugin-15671444-4.patch261.5 KB

Thanks droath! While waiting for the merge request to be merged, I have created a patch off of your MR.

ammar_ar’s picture

ammar_ar commented
StatusFileSize
new ckeditor_media_resize--2024-07-23-6.patch277.57 KB

Rerolled patch to work with 1.0.0-beta1

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
Parent issue: » #3463309: Plan for CKEditor Media Resize 1.0.0-beta2
StatusFileSize
new ckeditor_media_resize-n3458385-7.interdiff.txt765 bytes
new ckeditor_media_resize-n3458385-7.patch262.2 KB

Thank you for working on this.

I found some documentation around this API change: https://ckeditor.com/docs/ckeditor5/latest/updating/guides/update-to-41....

I think we should add this to beta2 and indicate it requires core 10.3, per this updated patch.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Add to rebuild the js but this worked like a charm also addresses #3450674: Ckeditor Media Resize breaks all ckeditor fields

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new ckeditor_media_resize-n3458385-9.patch896.22 KB

This adds the package-lock.json, and recompiles the plugin.

  • damienmckenna committed 3a232448 on 1.0.x 
    Issue #3458385 by damienmckenna, droath, vlyalko, ammar_jeetawi,...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks everyone.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.