Problem/Motivation

We recently added the gitlab CI pipeline for code checking.

The code does not pass all the tests.

Steps to reproduce

Check the recent gitlab pipeline run, for the failed tests.

Proposed resolution

Fix all the code styling warning.

Issue fork link_description_attributes-3458115

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

batigolix created an issue. See original summary.

nexusnovaz’s picture

nexusnovaz commented
Assigned: Unassigned » nexusnovaz

Ill take a look at this!

NexusNovaz opened merge request !2

nexusnovaz’s picture

nexusnovaz commented
Assigned: nexusnovaz » Unassigned
Status: Active » Needs work

Made a push to remove two unused use statements which is now passing phpcs which can be reviewed in MR !2. There is an issue with cspell which is erroring with:

Dictionary Error with (drupal) Error: ENOENT: no such file or directory, open '/builds/issue/link_description_attributes-3458115/web/core/misc/cspell/drupal-dictionary.txt'

. I'll mark as needs work for that issue.

Arantxio made their first commit to this issue’s fork.

arantxio’s picture

arantxio
Primary language Dutch
Location Dordrecht
commented
Status: Needs work » Needs review

@NexusNovaz, your issues with the test where due to a problem with the gitlab templates, this has been fixed now, I've rerun the test and saw that there were 2 words that needed ignoring.

This should fix the pipeline issues.

ankitv18’s picture

ankitv18 commented
Status: Needs review » Reviewed & tested by the community

Marking this one RTBC as changes are quite straightforward and pipelines are executed without any warning.

pilot3’s picture

pilot3 commented

Reviewed and verified that tests are passing in the pipeline.

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Fixed » Reviewed & tested by the community
batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Issue tags: -, -
batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -finalist-sprint, -gitlabci-contrib, -Novice

Thanks for the help on this one

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.