Problem/Motivation

We recently added the gitlab CI pipeline for code checking.

The code does not pass all the tests.

Steps to reproduce

Check the recent gitlab pipeline run, for the failed tests.

Proposed resolution

Fix all the code styling warning.

Remaining Tasks

Need to fix the final couple of suggestions from eslint.

/builds/issue/cookie_consent_notice-3458113/web/modules/custom/cookie_consent_notice-3458113/js/cookie_consent_notice.js
97:29 error Script URL is a form of eval no-script-url
115:17 error Prefer getComputedStyle to $.css jquery/no-css

Issue fork cookie_consent_notice-3458113

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

batigolix created an issue. See original summary.

NexusNovaz made their first commit to this issue’s fork.

NexusNovaz opened merge request !2

nexusnovaz’s picture

nexusnovaz commented
Issue summary: View changes
Status: Active » Needs work

Marking this as needs work. MR !2 should fix most issues, just a couple more for javascript which i am less knowledgeable on. Will leave for someone else to pick up! Updated the issue summary to reflect remaining task.

psebborn made their first commit to this issue’s fork.

psebborn’s picture

psebborn commented
Assigned: Unassigned » psebborn
Status: Needs work » Active
psebborn’s picture

psebborn commented
Status: Active » Needs review

Fixed the ESLint issues in the open MR now. https://git.drupalcode.org/project/cookie_consent_notice/-/merge_requests/2

Ready for review.

psebborn’s picture

psebborn commented
Assigned: psebborn » Unassigned
arantxio’s picture

arantxio
Primary language Dutch
Location Dordrecht
commented
Status: Needs review » Reviewed & tested by the community

All tests seem to pass and I see no unnecessary changes to the code.

roaldnel made their first commit to this issue’s fork.

roaldnel’s picture

roaldnel commented
Version: 1.0.1 » 1.0.2
Status: Reviewed & tested by the community » Fixed
roaldnel’s picture

roaldnel commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.