Problem/Motivation

We recently added the gitlab CI pipeline for code checking.

The code does not pass all the tests.

Steps to reproduce

Check the recent gitlab pipeline run, for the failed tests.

Proposed resolution

Fix all the code styling warning.

Issue fork mollie_donations-3458108

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

batigolix created an issue. See original summary.

daniel.j made their first commit to this issue’s fork.

daniel.j opened merge request !4

daniel.j’s picture

daniel.j commented
Status: Active » Needs review
Issue tags: -

Added a .gitlab-ci.yml file and implemented phpstan, phpcs and cspell fixes.

Gitlab CI pipeline passing (https://git.drupalcode.org/issue/mollie_donations-3458108/-/pipelines/32...).

Please review, thanks.

ankitv18’s picture

ankitv18 commented
Status: Needs review » Needs work

Added minor suggestions to MR, please check ~~ moving back into NW.

lavanyatalwar’s picture

lavanyatalwar commented

Working on the suggestions.

ankitv18’s picture

ankitv18 commented

Great~~ let me know once you are done

lavanyatalwar’s picture

lavanyatalwar commented
Status: Needs work » Needs review

@ankitv18, Done with the changes.
Kindly check

ankitv18’s picture

ankitv18 commented
Status: Needs review » Reviewed & tested by the community

Looks good ~~ Hence marking RTBC.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: -Novice

fabianderijk made their first commit to this issue’s fork.

fabianderijk’s picture

fabianderijk
him/his
Primary language Dutch
Location Alphen aan den Rijn
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -

Thanks for the good work. The MR is now merged and will be added in the new release.

ankitv18’s picture

ankitv18 commented

Hi @fabianderijk,
Thanks for merging this issue.
I guess you have missed to give credit to other contributors on this ticket. :)

fabianderijk’s picture

fabianderijk
him/his
Primary language Dutch
Location Alphen aan den Rijn
commented
fabianderijk’s picture

fabianderijk
him/his
Primary language Dutch
Location Alphen aan den Rijn
commented

Oops, added the credit to the users

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.