Closed (fixed)
Project:
Library Manager
Version:
2.0.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
27 Jun 2024 at 22:36 UTC
Updated:
16 Jul 2024 at 21:09 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
robingalipeau commentedComment #4
rishabjasrotia commentedComment #6
rishabjasrotia commentedComment #7
rishabjasrotia commentedComment #8
smulvih2@rishabjasrotia thanks for the MR! I tested this out locally and have the following feedback:
1. I added a new JS file to a library with the new options selected, but no changes were seen when viewing the actual JS file. I had to add the following to library_manager_build_libraries() in library_manager.module:
After adding the above I get the new attributes displaying correctly in the rendered output.
2. There should be a hook_update to add these new params to all existing library definitions.
New patch attached that addresses both of these points.
Comment #10
smulvih2This has been merged with the 2.0.x branch and will be included in next release. Thanks for your work on this @rishabjasrotia!