Problem/Motivation

The styling for the details element is too generic, this results in details outside of the editor also getting the styling. For example the stack traces in error messages, see the attached image.
Details outside of editor showing white text on white background

Steps to reproduce

Place a details element outside of the editor, see it also gets the editor styling. Or create an error with a stacktrace :)

Proposed resolution

Change the CSS so it is specific to the editor.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 3457207-11.patch714 bytestimohuisman
#4 3457207-4.patch987 bytesnvandijk
Screenshot 2024-06-26 at 10.13.41.png16.65 KBnvandijk

Issue fork ckeditor_details-3457207

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 3457207-styling-outside-editor Comparechanges, plain diff MR !5
  • 2.1.x Comparecompare
  • 2.x Comparecompare
About issue forks

Comments

nvandijk created an issue. See original summary.

nvandijk’s picture

nvandijk commented
Issue summary: View changes

nvandijk opened merge request !5

nvandijk’s picture

nvandijk commented
StatusFileSize
new 3457207-4.patch987 bytes

I have created a merge request, appending the .ck-editor class to ensure it only styles details within the editor.
Also adding a patch for own use.

idebr’s picture

idebr commented
Status: Needs review » Needs work

.ck-editor includes the toolbar. Let's use .ck-content so the css only applies to the editable content.

nvandijk’s picture

nvandijk commented
Status: Needs work » Needs review
idebr’s picture

idebr commented
Status: Needs review » Reviewed & tested by the community

Thanks!

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

cicciobat made their first commit to this issue’s fork.

cicciobat’s picture

cicciobat commented
Status: Needs work » Needs review
timohuisman’s picture

timohuisman
Primary language Dutch
Location Leiden, Netherlands
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll
StatusFileSize
new 3457207-11.patch714 bytes

Reroll looks good and the MR is green. Back to RTBC by #7.

Attached is a snapshot of the MR so it can be safely used with composer-patches.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.